http://www.magentocommerce.com/bug-tracking/ en MagentoCommerce Copyright {gmt_date format="%Y"} {gmt_date format="%Y-%m-%dT%H:%i:%s%Q"} http://www.magentocommerce.com/bug-tracking/issue?issue=8678 Posted: 2010-03-12 07:42:01
Category: Configuration
Version: 1.4.0.1
Priority: normal
Status: closed
Reported By: pmjacob

I detect an error in version 1.4.0.1.

Some translations are not working.

In function _otherText() in /app/code/core/Mage/Core/Model/Translate/Inline.php we have

[code]
if(-1 == $m[1][1])//title was not found - this is not an attribute
{

$tr = '{shown:''.$this->_escape($m[3][0]).'','
.'translated:''.$this->_escape($m[4][0]).'','
.'original:''.$this->_escape($m[5][0]).'','
.'location:'Text','
.'scope:''.$this->_escape($m[6][0]).''}';
$spanHtml = '<span translate='.$quoteHtml.'['.$tr.']'.$quoteHtml.'>'.$m[3][0].'</span>';
}
else
{
$spanHtml = $m[3][0];
}
$spanHtml = $m[3][0];
$this->_content = substr_replace($this->_content, $spanHtml, $m[2][1], strlen($m[2][0]) );
$next = $m[0][1];
[/code]

and after the if-else statement we get the same "$spanHtml = $m[3][0];" that is inside else statement.

In my case i've commented that line and most of the translations worked again.

---

]]> #1 / Comment by NoStress Commerce.

Hi,

look at my _otherText() method in file /app/code/core/Mage/Core/Model/Translate/Inline.php

I've remove some lines and it works very well for me. I hope that didn't break something else :-)

I attach my modified method below:



protected function _otherText()
{
if ($this->getIsJson()) {
$quoteHtml = '\"';
} else {
$quoteHtml = '"';
}

$next = 0;
$m = array();

while (preg_match('#(>|title=\")*('.$this->_tokenRegex.')#', $this->_content, $m, PREG_OFFSET_CAPTURE, $next)) {

{

$tr = '{shown:\''.$this->_escape($m[3][0]).'\','
.'translated:\''.$this->_escape($m[4][0]).'\','
.'original:\''.$this->_escape($m[5][0]).'\','
.'location:\'Text\','
.'scope:\''.$this->_escape($m[6][0]).'\'}';
$spanHtml = '<span translate='.$quoteHtml.'['.$tr.']'.$quoteHtml.'>'.$m[3][0].'</span>';
}

$this->_content = substr_replace($this->_content, $spanHtml, $m[2][1], strlen($m[2][0]) );
$next = $m[0][1];
}

}]]> #2 / Comment by mrgniarf

@ NoStress Commerce : your method works perfectly for me. No mater what is the text type, translate tools shows up as it shows in 1.3.2CE ! I just correct it to be cleaner :

protected function _otherText() {

if ($this->getIsJson()) {
$quoteHtml = '\"';
} else {
$quoteHtml = '"';
}

$next = 0;
$m = array();

while (preg_match('#(>|title=\")*('.$this->_tokenRegex.')#', $this->_content, $m, PREG_OFFSET_CAPTURE, $next)) {

$tr = '{shown:\''.$this->_escape($m[3][0]).'\','
.'translated:\''.$this->_escape($m[4][0]).'\','
.'original:\''.$this->_escape($m[5][0]).'\','
.'location:\'Text\','
.'scope:\''.$this->_escape($m[6][0]).'\'}';
$spanHtml = '<span translate='.$quoteHtml.'['.$tr.']'.$quoteHtml.'>'.$m[3][0].'</span>';


$this->_content = substr_replace($this->_content, $spanHtml, $m[2][1], strlen($m[2][0]) );
$next = $m[0][1];
}
}]]> #3 / Comment by Magento Team

fixed]]>