http://www.magentocommerce.com/bug-tracking/ en MagentoCommerce Copyright {gmt_date format="%Y"} {gmt_date format="%Y-%m-%dT%H:%i:%s%Q"} http://www.magentocommerce.com/bug-tracking/issue?issue=6656 Posted: 2009-06-19 00:35:43
Category: Product
Version: 1.3.0
Priority: high
Status: resolved
Reported By: duagne

Calling getMatchingProductIds() on a loaded CatalogRule rule model triggers an uncaught exception when the code attempts to explode() the array returned from $this->getWebsiteIds().

A check was added to this funciton in version 1.3.0, and if a rule has websiteIds() those ids are added to the filter of the productCollection being created. However, the check cannot work because it attempts to "explode" the website ids which were already "exploded" during the object's afterLoad().

Anyway, the fix is very easy. Simply change line 141 of app/code/core/Mage/CatalogRule/Model/Rule.php like this:

- $websiteIds = explode(',', $this->getWebsiteIds());
+ $websiteIds = $this->getWebsiteIds();

This is kind of a big deal to me, because our store has a custom module which calls this function and so this bug causes our entire site to crash.

---

]]> #1 / Comment by duagne

I included a patch. I promise it works :) Can't we just get this added to the next release of Magento?]]> #2 / Comment by Pihtt

duagne's patch remove exception but it has not been added in 1.4 release.
I wonder if this function getMatchingProductIds() really works. It's never used in magento core. I've tried to use it but the returned array is always empty for me.]]>