http://www.magentocommerce.com/bug-tracking/ en MagentoCommerce Copyright {gmt_date format="%Y"} {gmt_date format="%Y-%m-%dT%H:%i:%s%Q"} http://www.magentocommerce.com/bug-tracking/issue?issue=4252 Posted: 2008-11-28 06:45:33
Category: Dataflow (Export / Import)
Version: 1.1.8
Priority: high
Status: closed
Reported By: dogfoodmedia

Began receiving an error when the cron job attempted to update the Google Sitemap:

File "sitemap.xml" cannot be saved. Please, make sure the directory "/path/to/sitemaps/" is writeable by web server.

The path and the sitemap.xml are both writeable by the web server user. This error doesn't occur when you first generate the sitemap, only when you try to re-generate it.

Based on the above, I tracked the error down to two code snippets. The file depends on what the desired behavior is for Varien_Io_File::is_writeable.

Around line 113 of Mage_Sitemap_Model_Sitemap, we are throwing an exception if the sitemap file exists but is not writeable. However, only the filename is passed to $io->isWriteable() when that method appears to expect a full path. Therefore the exception is thrown even if the sitemap file is writeable (unless it happens to be in the cwd, i.e. html).

Quick fix - change line 113 from:

if ($io->fileExists($this->getSitemapFilename()) && !$io->isWriteable($this->getSitemapFilename())) {

to:

if ($io->fileExists($this->getSitemapFilename()) && !$io->isWriteable($this->getPath().$this->getSitemapFilename())) {

This adds the path to the argument passed to isWriteable.

However, the bug may actually be in Varien_Io_File. If so, the fix is:

public function isWriteable($path)
{
@chdir($this->_cwd);
$result = is_writeable( $path );
@chdir($this->_iwd);

return $result;
}

This then respects the path passed to the object on construction and interprets the call correctly.

---

]]> #1 / Comment by fsj911

I have EXACTLY the same issue on 1.1.8, and was on the same path. I'll be modifying the code per your suggestion - tired of email warnings every morning. Thanks!]]> #2 / Comment by pixelaté

Confirmed by another party, this is definitely an issue.]]> #3 / Comment by Magento Team

Hello dogfoodmedia,

This issue was fixed. The changes will be available in the next bugfix release.

Thank you.]]>