http://www.magentocommerce.com/bug-tracking/ en MagentoCommerce Copyright {gmt_date format="%Y"} {gmt_date format="%Y-%m-%dT%H:%i:%s%Q"} http://www.magentocommerce.com/bug-tracking/issue?issue=14297 Posted: 2012-10-04 05:30:52
Category: PayPal Integration
Version: 1.7.0.2
Priority: high
Status: new
Reported By: m4e

Trial orders are created with tax/shipping amounts calculated for regular billing amount, but not for trial billing amount.

Paypal recurring service supports separate values for trial tax/shipping amounts.
But the database table `sales_recurring_profile` does not contain columns for trial tax amount and trial shipping amount. Certainly they are not calculated during the checkout.

So while IPN-model processes the trial notification the tax and shipping values are empty (they were not POSTed). The trial product item is created via Mage_Sales_Model_Recurring_Profile::_getRegularItem method which contain the following code:
$price = $itemInfo->getPrice() ? $itemInfo->getPrice() : $this->getBillingAmount();
$shippingAmount = $itemInfo->getShippingAmount() ? $itemInfo->getShippingAmount() : $this->getShippingAmount();
$taxAmount = $itemInfo->getTaxAmount() ? $itemInfo->getTaxAmount() : $this->getTaxAmount();

On PayPal side the trial orders are charged without any tax nor shipping amount, because they were not sent by Magento during Recurring Profile creation.

So there are two way to fix it: create trial orders with zero tax/shipping amounts, similar to they are created on PayPal side, or Magento should calculate these amounts for trial billing amount, send them to PayPal so the amounts will be sent within IPN request and the Magento order will have the correct amounts and totals.

The quick fix for the first way is to replace
... = $itemInfo->getPrice() ? ...
... = $itemInfo->getShippingAmount() ? ...
... = $itemInfo->getTaxAmount() ? ...
with the following
... = $itemInfo->hasPrice() ? ...
... = $itemInfo->hasShippingAmount() ? ...
... = $itemInfo->hasTaxAmount() ? ...

But the second way to fix is preferred.
Thank you.

---

]]>