Posting in the Magento forums has been disabled pending the implementation of a new and improved forum solution which should better serve the community.

For new questions please post at magento.stackexchange.com, the community-run support site for the Magento community. We will be providing updates on the new forum solution soon. For questions or concerns please email community@magento.com.

Magento Forum

Fairly significant cruft in model product
 
Mark_Kimsal
Sr. Member
 
Total Posts:  186
Joined:  2007-09-12
Michigan, USA
 

app/code/core/Mage/Catalog/Model/Product.php

(871) importFromTextArraySilently(array $row)

and

(761) importFromTextArray(array $row)

are almost 100% the same, with the exception that one prints error messages and the other doesn’t.  This can easily be consolidated into 1 method calling the other with a flag to print errors.

The real danger here is that one simply “returns” on error and one “returns false;”.

Thus, making

$product->importFromTextArray(array()) !== false
but
$product->importFromTextArraySilently(array()) === false
 
Magento Community Magento Community
Magento Community
Magento Community
Magento Community
Magento Community
Back to top