Magento

magicker - 11 December 2009 02:35 PM

I can confirm that updating from 1.3.2.3 to 1.3.2.4 and making the changes below fixes the following:

grand total order double
customer paid double
paypal order defaulting to complete instead of processing

My Standard.php file now looks like:

147     public function canCapture()
148     {
149         return true;
150     }

.....  .........

417     $invoice->register()->pay();
418              Mage::getModel('core/resource_transaction')
419            ->addObject($invoice)
420         ->addObject($invoice->getOrder())
421          ->save();
422        $order->setState(
423        Mage_Sales_Model_Order::STATE_PROCESSING, $newOrderStatus,
424           Mage::helper('paypal')->__('Invoice #%s created', $invoice->getIncrementId()),
425           $notified = true

I’m on 1.3.1.1. Does anyone know if this solution works for this version?
For me I only change

$invoice->register()->capture();

to

$invoice->register()->pay();

still waiting for the first incoming order to see if it works.

Magicker’s two fixes worked for me as well on a fresh install of 1.3.2.4.  “Total Paid” is now correct, and order status is correct set to “Processing” instead of Completed.

Thanks!

--
Fright Ideas

The fix works great!

However, I suspect that there is another bug with paypal.

When the customer pays using paypal the invoice is generated and marked as “notified to the customer”. However, the email with the invoice is not send to the customer.

Thank you for the fix!

Since no one answered this

file location is here

app/code/core/mage/paypal/model/Standard.php

Thanks kwave and magicker.  Was exactly the solution I needed.  Works in 1.3.2.4.

Interesting post guys.

Any ideas on how to handle the coupon problem with paypal. The coupon is being registered if I accept bank prepayment at the order review (final stage), however, not if the customer pays with paypal standard.

Thanks for the help.

Paypla still has a problem.

I had to allow all countries to get over the problem of paypal express.

Its on my site: Modern Chairs

I applied the the modifications suggested here and initial issues with order status and double total amount have disappeared.
I am still experiencing a problem with tax though:

When I am inside Magento Checkout taxes are calculated ok.
Then when payment is made in Paypal the order is updated and I get two new tax records with weird amounts. My totals are still ok though. It’s just when I look into the tax detail that I see the new records.

Any clue anyone?

(See attached screen shots)

Click thumbnail to see full-size image

danim - 02 February 2010 12:44 AM

The fix works great!

However, I suspect that there is another bug with paypal.

When the customer pays using paypal the invoice is generated and marked as “notified to the customer”. However, the email with the invoice is not send to the customer.

Thank you for the fix!

Hello,

I have the same problem, does anyone has a solution for this?

Cheers,

Jord

Hi,
I also have this problem that the customer isn’t informed. There’ just a paypal assignment for succesfull payment. It is very important for me to inform the customer per Shopmail.
Has anyone found a solution?

Thanks, Very Helpful ! 

Great work done by magento developer.

Dx3webs - 11 December 2009 02:35 PM

I can confirm that updating from 1.3.2.3 to 1.3.2.4 and making the changes below fixes the following:

grand total order double
customer paid double
paypal order defaulting to complete instead of processing

My Standard.php file now looks like:

147     public function canCapture()
148     {
149         return true;
150     }

.....  .........

417     $invoice->register()->pay();
418              Mage::getModel('core/resource_transaction')
419            ->addObject($invoice)
420         ->addObject($invoice->getOrder())
421          ->save();
422        $order->setState(
423        Mage_Sales_Model_Order::STATE_PROCESSING, $newOrderStatus,
424           Mage::helper('paypal')->__('Invoice #%s created', $invoice->getIncrementId()),
425           $notified = true

i have used the same code in my magento 1.3.2.3, but it takes the Complete status instead of Processing. we have virtual products.
Please replay. i dont find any solutions for the same.

To fix this issue follow these simple steps below.

Locate File: app/code/core/Mage/Paypal/Model/standard.php

On line 423 you should have this line of code:
Mage_Sales_Model_Order::STATE_COMPLETE, true,

Replace this line with
Mage_Sales_Model_Order::STATE_PROCESSING, true,

Save and upload and this will set new paypal orders to processing when payment is complete.