Posting in the Magento forums has been disabled pending the implementation of a new and improved forum solution which should better serve the community.

For new questions please post at magento.stackexchange.com, the community-run support site for the Magento community. We will be providing updates on the new forum solution soon. For questions or concerns please email community@magento.com.

Magento Forum

Page 2 of 4
Another Bug - After successful checkout, the cart is not empty
 
alex.bsc
Guru
 
Total Posts:  340
Joined:  2008-06-06
 

man i’m so glad i’m waiting out the 1.2 bugfixes. i need some 1.2 features quite urgently, but not at the price of having ssl, cart and search issues - the most important things in any cart.

 
Magento Community Magento Community
Magento Community
Magento Community
 
golles
Sr. Member
 
Total Posts:  257
Joined:  2008-01-15
 

OK

I think we have pretty much isolated this to an issue with the Protx Direct Module.

Protx direct installed - cart does not empty and no thank you page - even if you select another checkout method - like cheque or paypal

Completely uninstall Protx Direct via Magento connect and checkout works fine with thank you page showing for both paypal and cheque payment methods.

Can somebody else test this and confirm their findings too.

We have just tried on our dev and staging environments and both work fine with the Protx Direct module completely removed.

 
Magento Community Magento Community
Magento Community
Magento Community
 
golles
Sr. Member
 
Total Posts:  257
Joined:  2008-01-15
 

see:
http://www.magentocommerce.com/boards/viewthread/27819/#t91371

 
Magento Community Magento Community
Magento Community
Magento Community
 
House of Type
Jr. Member
 
Total Posts:  14
Joined:  2009-01-07
 

Hi Guys,

Just thought I’d share some info with you. I’ve just a fresh install on my machine of 1.2.0 and installed the protx module, and everything worked fine.

I put a test order through on the check / postal order module without the protx module and it worked fine,
I then installed the protx module and went back and added the product to my cart and used the same shiping address etc and the order went through fine.

I then upgraded to 1.2.0.1 and repeated the steps again, and it worked fine without the module, but as soon as I installed the module it then proceeded to error.

So it appears that theres something in 1.2.0.1 which has caused the protx module to act weirdly.

 
Magento Community Magento Community
Magento Community
Magento Community
 
House of Type
Jr. Member
 
Total Posts:  14
Joined:  2009-01-07
 

Another quick note, maybe someone can expand on what I’ve learnt.

app/code/core/mage/checkout/controllers/OnepageController.php

There is a SuccessAction() function which is redirecting to the cart rather than the success page.

It is check this:  if (!$this->getOnepage()->getCheckout()->getLastSuccessQuoteId()) {
and failing, so redirect to the cart, this is on line 169.

I’ll keep looking into this tomorrow (its 2am here) and will see if I can get a solution together.

 
Magento Community Magento Community
Magento Community
Magento Community
 
House of Type
Jr. Member
 
Total Posts:  14
Joined:  2009-01-07
 

Hi guys,

just a quick update, I believe I have resolved the problem, basically the protx module creates a new SaveOrder function, and this is being used rather than the default one (which is strange behaviour IMO - however I’m sure theres a reason).

Anyway, in this saveorder function it is not setting a Last Success Quote id by calling setLastSuccessQuoteId, basically the following lines need to be added.

in: /app/code/local/B4Before/Checkout/Model/Type/Onepage.php

just below (around line 168)

$orderId $order->getIncrementId();
$this->getCheckout()->setLastQuoteId($this->getQuote()->getId());
$this->getCheckout()->setLastOrderId($order->getId());
$this->getCheckout()->setLastRealOrderId($order->getIncrementId());
$this->getCheckout()->setRedirectUrl($redirectUrl);

enter the following lines at around line 174

//Setting this one more time like control flag that we haves saved order
//Must be checkout on success page to show it or not.
$this->getCheckout()->setLastSuccessQuoteId($this->getQuote()->getId());

that should fix it, I haven’t done any thorough testing, but will do that tomorrow (its now 2:30am) but at the moment it seems to resolve the problem.

 
Magento Community Magento Community
Magento Community
Magento Community
 
House of Type
Jr. Member
 
Total Posts:  14
Joined:  2009-01-07
 

Hi everyone,

I’ve been testing the fix and everything appears fine to me, and I’m about to role it out to our live site (since we installed 1.2.0.1 without realising there was this bug).

But I would still like to know if anyone else seems to be having a problem

regards

James

 
Magento Community Magento Community
Magento Community
Magento Community
 
Redhat
Jr. Member
 
Total Posts:  16
Joined:  2008-07-06
Tel Aviv
 

I applied the fix to both systems i run and tested it.

All seems fine and working as expected.

Many thanks to James (House of Type) who managed to solve it and is so kind to share the solution with the community.

 
Magento Community Magento Community
Magento Community
Magento Community
 
Tabizan
Jr. Member
 
Total Posts:  10
Joined:  2008-11-12
 

Yeah, thanks a lot James, I can go live now grin

 
Magento Community Magento Community
Magento Community
Magento Community
 
Dave Smith
Member
 
Avatar
Total Posts:  58
Joined:  2008-02-03
Tamworth, UK
 

Awesome James. Thank you.

 
Magento Community Magento Community
Magento Community
Magento Community
 
Nick Rigby
Member
 
Total Posts:  57
Joined:  2007-09-03
 

James, you are a legend.

Thanks for the fix, works a treat.

 
Magento Community Magento Community
Magento Community
Magento Community
 
ajbattrick
Jr. Member
 
Total Posts:  4
Joined:  2009-01-23
 

I had the same issue with 1.2.0.2 and it is resolved now - though I have not tested if 3DSecure payments go through as expected. I expect that is where the source of the redirect problems occur.

 
Magento Community Magento Community
Magento Community
Magento Community
 
ebizmarts
Mentor
 
Avatar
Total Posts:  2202
Joined:  2008-03-10
Montevideo, Uruguay
 

New version of the Protx Direct payment module, compatible with Magento 1.2, has been uploaded.

***As usual, give it a try on a test site before installing on a Live site***

Thanks all for your help, specially “House of Type” for sharing the fix to the redireciton issue.

 
Magento Community Magento Community
Magento Community
Magento Community
 
iboxsecuritydotnet
Jr. Member
 
Total Posts:  18
Joined:  2009-01-03
 

running the latetest magento fresh install and having the problem whether i try and use SAVED CC or PayPal of any kind i keep getting redirected to cart again! This site is meant to go live in a day or two and ive been trying to fix this for over a week. Applied above fix but nothing helps. NOT using Protx but CC or Paypal. Any clues?

 
Magento Community Magento Community
Magento Community
Magento Community
 
ebizmarts
Mentor
 
Avatar
Total Posts:  2202
Joined:  2008-03-10
Montevideo, Uruguay
 

iboxsecuritydotnet, the patch submited only applies to the Protx Direct Payment module, it won’t help you with other payment methods.

 
Magento Community Magento Community
Magento Community
Magento Community
Magento Community
Magento Community
Back to top
Page 2 of 4